Revert "Do not do redirect handling when loggin out"#40407
Conversation
kesselb
force-pushed
the
revert-pr-12573
branch
from
cf77375 to
bed74ea
Compare
|
Good finding 👍 |
kesselb
requested review from
ChristophWurst,
come-nc,
nickvergessen and
rullzer
|
What's keeping this from getting merged? |
The failing DCO check, for example. |
haslersn
force-pushed
the
revert-pr-12573
branch
from
bed74ea to
4aad91c
Compare
|
@kesselb is was signed off, but apparently there was a mismatch between committer email and sign-off email. Should be fixed now. |
haslersn
force-pushed
the
revert-pr-12573
branch
from
4aad91c to
07640e5
Compare
|
What's now keeping this from getting merged? |
come-nc
force-pushed
the
revert-pr-12573
branch
from
07640e5 to
3b69063
Compare
|
I rebased for CI, I do not understand enough about this for approving, I’ll follow @kesselb lead on this one. |
|
Hello Hello, it's been a while and I don't remember all the details. I think the middleware was added to address the redirect cause by clear-site-data executionContext and can, as we removed executionContext again, go. |
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: nextcloud#16310 Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Rebased, otherwise looks fine
9 participants
This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: #16310
Checklist